temporalio / temporalio/sdk-typescript
Incompatible with allowSyntheticDefaultImports set to false
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 917
- Forks
- 224
- Avg merge
- 3d 16h
- Merged PRs (30d)
- 43
Description
Your tsconfig.json seems to have allowSyntheticDefaultImports and esModuleInterop set to true. This makes TypeScript throw errors when using the SDK in a project that has decided to not use these legacy support flags any more.
We were able to work around this with very small patches to your code, e.g. use import * as webpack from 'webpack'; instead of import webpack from 'webpack';, so I believe it would be easy and helpful if you would disable these flags in the SDK as well.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the SDK's tsconfig.json and inspect how allowSyntheticDefaultImports and esModuleInterop are configured. Review the affected imports, including webpack imports mentioned in the issue, and verify that the SDK builds and remains usable when both flags are disabled.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100