temporalio / temporalio/sdk-typescript

[Feature Request] Throw when `heartbeat()` is called from Local Activities

Open
#828 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement next-gen
Dominant language
TypeScript
Stars
917
Forks
224
Avg merge
3d 16h
Merged PRs (30d)
43

Description

This is what Python does. It's a way to indicate to users that they don't need that line of code (which currently is ignored / has no effect).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the TypeScript implementation of heartbeat() and the code path that handles Local Activities; compare its behavior with the Python SDK. Make heartbeat() throw when invoked from a Local Activity, and verify that calls from other supported contexts remain unaffected.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
backend-api-design
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.