temporalio / temporalio/sdk-rust
[Feature Request] Switch tests to use tokio::time::advance instead of sleep
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 523
- Forks
- 161
- Avg merge
- 1d 7h
- Merged PRs (30d)
- 67
Description
Is your feature request related to a problem? Please describe.
Spencer found tokio::time::advance, we can maybe use this to speed up some of our tests
Describe the solution you'd like
Replace uses of sleep to advance to speed up tests
Additional context
I took an initial stab at replacing all test instances of sleep, saw a bunch of test errors and a few test hangs. Didn't dig into the failures too much. May not be as straightforward as I originally thought. advance-time-on-tests contains the initial naive attempt at the conversion
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the advance-time-on-tests branch and its reported failures and hangs, then locate the test uses of sleep that need investigation. Done means the applicable tests use tokio::time::advance, complete without failures or hangs, and run faster.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- testing-qa
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100