temporalio / temporalio/sdk-rust
[Feature Request] Do not warn about missing activity on activity cancel
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 523
- Forks
- 161
- Avg merge
- 1d 7h
- Merged PRs (30d)
- 67
Description
Is your feature request related to a problem? Please describe.
If I just start an activity, cancel it, and wait on the task (which has TRY_CANCEL by default), and return from the workflow I get this warning:
Activity not found on completion. This may happen if the activity has already been cancelled but completed anyway.
At least I believe that is what is happening.
Describe the solution you'd like
Don't show that log if this is an activity cancel since sometimes it is the workflow leaving that is causing the cancel (and other times the workflow may be gone for other reasons). Or maybe reduce the log level.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the Rust repository for the warning text "Activity not found on completion" and trace the completion path used after an activity cancellation. Reproduce the described start-cancel-wait-workflow-return scenario, then verify that the warning is suppressed or logged at a lower level specifically for cancellation while other missing-activity cases retain their existing behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- distributed-systems
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100