temporalio / temporalio/sdk-rust
[Feature Request] Support ignoring invalid server certificates
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 523
- Forks
- 161
- Avg merge
- 1d 7h
- Merged PRs (30d)
- 67
Description
Is your feature request related to a problem? Please describe.
In Go we can use InsecureSkipVerify on tls.Config and in Java we can call setUseInsecureTrustManager, but there is no equivalent in Core.
Describe the solution you'd like
We need some kind of ignore_invalid_server_cert boolean. I don't think we want to just call it insecure because that implies a lot. And I could see one day people want more control over which errors they ignore on invalid server, but I think this would solve most needs for now.
Other users wanted to do similar, e.g. https://github.com/hyperium/tonic/issues/891#issuecomment-1152846600. https://github.com/hyperium/tonic/blob/master/examples/src/tls/client_rustls.rs is an example of custom TLS. We might have to use something like Endpoint.connect_with_connector and make our own connector. Or maybe we can upstream something to tonic.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the linked tonic custom TLS client example and the Endpoint.connect_with_connector documentation. Determine whether Core can expose an ignore_invalid_server_cert option directly or needs a connector or upstream tonic change. Done means the requested certificate-ignoring behavior is available without broadly naming the option insecure.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- networking, security
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100