temporalio / temporalio/sdk-python

[Feature Request] Implement proper behavior for `cancelled`, `uncancel`, and `cancelling` of activities and child workflows

Open
#810 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Python
Stars
1.2k
Forks
241
Avg merge
3d 21h
Merged PRs (30d)
55

Description

Describe the solution you'd like

Implement proper behavior for cancelled, uncancel, and cancelling of activities and child workflows. The behavior probably looks like:

  • cancelled - return true once it comes back as canceled
  • uncancel - raise an (non-Temporal) exception saying that uncancel is not supported
  • cancelling - probably just works already

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Search the Python SDK for the implementations of activity and child-workflow cancellation, including the cancelled, uncancel, and cancelling APIs. Run the related cancellation tests, then verify that cancelled reflects the returned cancellation state, uncancel raises the intended exception, and existing cancelling behavior remains correct.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend, distributed-systems
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.