temporalio / temporalio/sdk-python
[Feature Request] Turn invalid asyncio call warnings into errors
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- Python
- Stars
- 1.2k
- Forks
- 241
- Avg merge
- 3d 21h
- Merged PRs (30d)
- 55
Description
Describe the solution you'd like
As part of #533, we are warning if asyncio.as_completed() or asyncio.wait() are invoked in workflows because they are non-deterministic. After a release and a good period of time, we should fail when these are called the same way we do with other invalid workflow calls.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the warning implementation from #533 and how other invalid workflow calls are handled. Update the behavior for asyncio.as_completed() and asyncio.wait() so the warned workflow usage fails as an error after the transition period, and verify the existing invalid-call tests cover the new behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100