temporalio / temporalio/sdk-python
[Feature Request] Warn when non-static activity method registered as static
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- Python
- Stars
- 1.2k
- Forks
- 241
- Avg merge
- 3d 21h
- Merged PRs (30d)
- 55
Description
Describe the solution you'd like
If possible, if an activity's first parameter is self but it's not an instance method, warn when creating the worker. This means the instance wasn't instantiated.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at worker creation and the activity registration path, focusing on how the activity's first parameter and instance-method status are inspected. Determine how a non-static activity with a first parameter of self can be identified when registered as static. Done means the worker emits a warning for this case without warning for valid registrations, with coverage for the behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100