temporalio / temporalio/sdk-python
[Feature Request] Log and drop signals that pass the wrong number of arguments
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1.2k
- Forks
- 241
- Avg merge
- 3d 21h
- Merged PRs (30d)
- 55
Description
Describe the solution you'd like
In #349 we now drop signals whose arguments are of the wrong type. But we still fail the workflow task if the arity is off, e.g. with Python exceptions like "missing 1 required positional argument". Try to make sure there is one argument for every required parameter and no more than accepted (varargs notwithstanding). May be easiest to have a min/max param count on the _SignalDefinition and just check against that.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the _SignalDefinition implementation and the behavior introduced in #349, then trace where signal arguments are validated and invoked. Done means signals with too few or too many arguments are logged and dropped without failing the workflow task, while accepted varargs continue to work.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100