temporalio / temporalio/sdk-php
[Feature Request] Rename `ActivityPrototype::getHandler` to `getMethodReflection`
Open
Beginner friendly
Nobody has claimed this yet.
enhancement
- Dominant language
- PHP
- Stars
- 421
- Forks
- 64
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 11
Description
Is your feature request related to a problem? Please describe.
ActivityPrototype::getHandler does not, in fact, return a handler. MethodHandler is the handler.
Describe the solution you'd like
Rename to ActivityPrototype::getMethodReflection, similar to getMethodRetry.
Additional context
As always, my hand is up for implementation should you decide this is to your liking.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating ActivityPrototype::getHandler and its references, then compare the naming with getMethodRetry as described in the issue. The work is done when the method and its references use getMethodReflection consistently and the misleading getHandler name is removed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend-api-design
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Active
- Clarity
- Clearly specified
- Newbie friendliness
- 78/100