temporalio / temporalio/sdk-php
[Feature Request] Forward options for worker heartbeating
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 421
- Forks
- 64
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 11
Description
Is your feature request related to a problem? Please describe.
Worker-level heartbeating is implemented in Go, we need to make sure users can disable it if desired via configuration. See https://github.com/temporalio/features/issues/696
Describe the solution you'd like
Pass through option for https://github.com/temporalio/sdk-go/blob/f0db526a5db8e8f4cd1c79501aa9cb795bf8d578/internal/client.go#L612
Ensure sdk name/version/other info that is recorded in the heartbeat is accurate
Additional context
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing the PHP SDK's worker heartbeating configuration with the referenced sdk-go internal/client.go entry point at line 612. Add the configuration pass-through and verify that the heartbeat records accurate SDK name, version, and other information; the issue does not name a PHP file or test to run.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go, php
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100