temporalio / temporalio/sdk-java
Workflow should be able to ignore CancellationFailure and finish successfully
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 433
- Forks
- 249
- Avg merge
- 5d 6h
- Merged PRs (30d)
- 26
Description
Expected Behavior
Workflow code should be able to catch CancellationFailure, handle or ignore it and be able to finish executing successfully.
Test https://github.com/Spikhalskiy/java-sdk/commit/eada50399b6d24c77d4b6e37cd500907594a189a#diff-a2baafb2fd6213bafb49077bd60c8efeedc6c15df86437e9c8e2ef87ce23625cR58
expected to pass
Actual Behavior
Test fails. Workflow doesn't get a chance to fully swallow and ignore CancellationFailure and is forced to finish with EVENT_TYPE_WORKFLOW_EXECUTION_CANCELED
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the failing test referenced in commit eada50399b6d24c77d4b6e37cd500907594a189a and trace how CancellationFailure is handled during workflow execution. Done means the workflow can catch, handle, or ignore CancellationFailure, complete successfully, and no longer be forced to finish with EVENT_TYPE_WORKFLOW_EXECUTION_CANCELED.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend, distributed-systems
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100