temporalio / temporalio/sdk-java
activity_schedule_to_start_latency reports activity_type unexpectedly
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 433
- Forks
- 249
- Avg merge
- 5d 6h
- Merged PRs (30d)
- 26
Description
How to repro - run the java sdk samples metrics sample: https://github.com/temporalio/samples-java/tree/main/core/src/main/java/io/temporal/samples/metrics
Sample starts only 2 activities, PerformA and PerformB. Metrics report activity_schedule_to_start_latency for 3 activities, PerformA, PerformB and "none" which is the default.
Per docs this metric should not be reporting activity_type at all, but it is, and its also confusing why its reporting it for "none", I believe this is done on activity failure since in sample activities are being retried couple times.
Request is to either fix activity_schedule_to_start_latency to always report activity_type (which would be pretty useful if possible) or to not report it at all, and leave task_queue as lowest granularity for this metric.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by running the Java SDK metrics sample in core/src/main/java/io/temporal/samples/metrics and reproducing activity_schedule_to_start_latency for PerformA, PerformB, and "none". Compare the observed activity_type labels with the documentation and determine whether the metric should consistently include activity_type or omit it, then verify the chosen behavior under activity retries.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- observability
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100