temporalio / temporalio/sdk-java
[Feature Request] Add counter metric for unaccessed failed promises
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 433
- Forks
- 249
- Avg merge
- 5d 6h
- Merged PRs (30d)
- 26
Description
Would be useful to have a counter metric for this. Would allow detection so can fix in code if was oversight not to wait on promise,or ignore warning via something like
promise.exceptionally(e->null);
or promise.handle((ex, failure) -> null);
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in temporal-sdk/src/main/java/io/temporal/internal/sync/DeterministicRunnerImpl.java at lines 336-347, where unaccessed failed promises are handled. Trace the existing warning path and determine how a counter metric should represent this condition. Done means the metric is emitted for unaccessed failed promises and the behavior is covered by the relevant tests identified while reading the runner.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- observability-sre
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100