temporalio / temporalio/sdk-java

Child workflow cancellation can trigger SDK event loop without a WFT Started

Open
#2,160 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
433
Forks
249
Avg merge
5d 6h
Merged PRs (30d)
26

Description

Expected Behavior

Child workflow cancellation would not trigger the event loop without a WFT Started

Actual Behavior

Child workflow cancellation can trigger SDK event loop without a WFT Started

Steps to Reproduce the Problem

see: https://github.com/temporalio/sdk-java/issues/2155

https://github.com/temporalio/sdk-java/blob/eabd51fbdc62a7435c8f4d8dc1ac24da26f6022d/temporal-sdk/src/main/java/io/temporal/internal/statemachines/WorkflowStateMachines.java#L884

Fixing this would be a non deterministic change so we will need to version this change.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with temporal-sdk/src/main/java/io/temporal/internal/statemachines/WorkflowStateMachines.java around line 884 and review the related reproduction in sdk-java issue 2155. Trace child-workflow cancellation and the event-loop behavior, then determine how the versioning requirement affects the fix. Done means cancellation no longer triggers the SDK event loop without a WFT Started while preserving the required versioning behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
distributed-systems
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.