temporalio / temporalio/sdk-java
Revisit local activity backpressure logic w/ no-max slot suppliers
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 433
- Forks
- 249
- Avg merge
- 5d 6h
- Merged PRs (30d)
- 26
Description
Before slot supplier introduction, there was a backpressure semaphore for LAs sized at 2x the number of concurrent executions which, when the limit is reached, fails the WFT.
After suppliers, this behavior is the same, but for suppliers with no defined upper-limit on slots, there is no way to pick a reasonable number, so we default to 100. See if there's anything better to be done here.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the local activity backpressure semaphore and the slot supplier handling described in this issue. Compare the fixed default of 100 for suppliers without an upper limit with the existing bounded-supplier behavior; done means determining and implementing a more appropriate approach, if one exists.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend, performance
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100