temporalio / temporalio/sdk-java
activity_succeed_endtoend_latency not reported when completing the activity with ActivityCompletionClient
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 433
- Forks
- 249
- Avg merge
- 5d 6h
- Merged PRs (30d)
- 26
Description
Expected Behavior
The metric activity_succeed_endtoend_latency should be reported when activity is completed with ActivityCompletionClient.complete
I think it is missing in this method https://github.com/temporalio/sdk-java/blob/0c8073ee74984333f045b79a27da337097d7ae7a/temporal-sdk/src/main/java/io/temporal/internal/client/external/ManualActivityCompletionClientImpl.java#L101
Actual Behavior
Metric is not reported, you can find a reproduction here https://github.com/antmendoza/my-temporal-pocs/tree/main/java/pocs/src/main/java/io/antmendoza/samples/_6442.
Steps to Reproduce the Problem
Specifications
- Version:
- Platform:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in temporal-sdk/src/main/java/io/temporal/internal/client/external/ManualActivityCompletionClientImpl.java at the complete method, then run the linked reproduction in the _6442 sample. Trace completion through the client and verify that activity_succeed_endtoend_latency is reported when ActivityCompletionClient.complete is used.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- observability
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100