temporalio / temporalio/sdk-java
Log server-side task failure caused by invalid command in test server
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 433
- Forks
- 249
- Avg merge
- 5d 6h
- Merged PRs (30d)
- 26
Description
Describe the solution you'd like
Today io.temporal.internal.testservice.CommandVerifier.verifyCommand is called on each command to make sure valid or a task failure occurs. Since this is not a task failure caused by caller and there is no UI for Java test server, this is just silently failed. We should log (where it's called from TestWorkflowMutableStateImpl). This only applies to search attributes today, because that's the only thing we check command validity on (we don't need to log unhandled command, that's a normal state of operation).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at io.temporal.internal.testservice.CommandVerifier.verifyCommand and trace its call from TestWorkflowMutableStateImpl. Confirm how invalid search-attribute commands currently produce task failures, then add server-side logging for those failures without logging unhandled commands. Done means invalid command failures are visible in test-server logs.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- testing-qa
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 56/100