temporalio / temporalio/sdk-java
Unit Test for ActivityCompletionClient methods that don't use taskToken
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 433
- Forks
- 249
- Avg merge
- 5d 6h
- Merged PRs (30d)
- 26
Description
All the methods of ActivityCompletionClient that don't use task token and use String workflowId, Optional<String> runId, String activityId instead are unused and untested.
The same is ManualActivityCompletionClientImpl codepaths that work when workflowId + activityId are specified instead of taskToken.
These methods should be covered with basic unit tests.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate ActivityCompletionClient methods that accept workflowId, Optional runId, and activityId, then inspect the corresponding ManualActivityCompletionClientImpl codepaths. Add basic unit tests covering these workflowId-and-activityId variants without taskToken, and verify the tests exercise all identified methods.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- testing
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 40/100