temporalio / temporalio/sdk-java
Revisit history pagination
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 433
- Forks
- 249
- Avg merge
- 5d 6h
- Merged PRs (30d)
- 26
Description
Is your feature request related to a problem? Please describe.
WorkflowHistoryIterator implementation related to deadline (using calculations on curentTimeMilles), exceptions handling and error/expiration reporting requires a revisit and polishing.
Logging should include more information about the workflow task timeout and how much time elapsed.
As a part of this task it's also a good idea to build-in protection from the server returning events in a loop that never ends that we have in Core:
https://github.com/temporalio/sdk-core/blob/a72ebed19ec1e7b3fe37fbcbe846deafb1820f33/core/src/worker/workflow/history_update.rs#L281
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the WorkflowHistoryIterator implementation and compare its deadline calculations, exception handling, and reporting with the referenced core/src/worker/workflow/history_update.rs logic. Review how timeout logging is produced and determine the expected termination behavior when the server repeats events; done means these concerns are specified and covered by the relevant tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, rust
- Domain
- distributed-systems
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100