temporalio / temporalio/sdk-java

Workflow metadata resolution code registers an overridden method from parent class as a second query

Open
#1,107 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Java
Stars
433
Forks
249
Avg merge
5d 6h
Merged PRs (30d)
26

Description

Expected Behavior

Such a workflow interfaces hierarchy:

@WorkflowInterface
public interface ReportingWorkflow extends TemporalWorkflow<ReportQueriesResponse> {
  @WorkflowMethod
  ReportQueriesResponse runReport(ReportQueries reportQueries);

  @QueryMethod
  @Override
  ReportQueriesResponse getResults();
}

public interface TemporalWorkflow<T> extends TemporalRunnable {
  T getResults();
}

should be fine.

Actual Behavior

Triggers java.lang.IllegalArgumentException: Duplicated name of QUERY: "getResults" declared at "public abstract xxx.ReportingProto$ReportQueriesResponse xxx.ReportingWorkflow.getResults()" and "public default java.lang.Object xxx.ReportingWorkflow.getResults()"

Specifications

  • Version: 1.8.x

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the failure with the ReportingWorkflow and TemporalWorkflow hierarchy shown in the issue, then trace the workflow metadata resolution code that registers query methods. Done means the overridden getResults method is recognized once rather than being registered again as the generated default bridge method, without the duplicated QUERY exception.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.