temporalio / temporalio/sdk-java
Issue with TestWorkflowEnvironment and ParentClosePolicy
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 433
- Forks
- 249
- Avg merge
- 5d 6h
- Merged PRs (30d)
- 26
Description
It looks as during testing child workflow thats started async, with ChildWorkflowOptions->setParentClosePolicy is TERMINATE
when the parent completes, the child workflow is not terminated, but still is allowed to complete.
Reproducer: https://github.com/tsurdilo/test-reproducer
Clone repo, run "mvn clean install"
You will see test fail with:
org.junit.ComparisonFailure:
Expected :WORKFLOW_EXECUTION_STATUS_TERMINATED
Actual :WORKFLOW_EXECUTION_STATUS_COMPLETED
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Clone the linked test-reproducer repository and run "mvn clean install" to reproduce the failure involving TestWorkflowEnvironment and ChildWorkflowOptions.setParentClosePolicy. Trace the parent and asynchronously started child workflow behavior, then verify that the child ends with WORKFLOW_EXECUTION_STATUS_TERMINATED rather than COMPLETED.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend, distributed-systems
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100