temporalio / temporalio/samples-server
[Bug] Bumping to temporal admin tools version 1.31.0 breaks default pg-es compose setup
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 124
- Forks
- 71
- PR merge metrics
- No merged PRs in 30d
Description
What are you really trying to do?
Use the default compose setup
Describe the bug
https://github.com/temporalio/samples-server/pull/148
this PR broke the default compose setup as container versions of temporal after 1.30 where shipped without curl.
https://github.com/temporalio/samples-server/blob/ca1106b647c34323876bd6f221f4310271096dd8/compose/scripts/setup-postgres-es.sh#L32
Minimal Reproduction
Ran docker compose up
checked the logs of admin-tools container:
Elasticsearch not ready yet, waiting... (attempt 19/30) /scripts/setup-postgres-es.sh: line 68: curl: not found
got sad 😩.
Environment/Versions
- OS and processor: intel i7 something, Linux
- Temporal Version: 1.31.0
- Docker compose
Additional context
Also, I believe the script is not passing postgres password to temporal-sql-tool
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with compose/scripts/setup-postgres-es.sh, especially the readiness check around lines 32 and 68, then run docker compose up and inspect the admin-tools logs. Confirm the default compose setup completes with Temporal 1.31.0, and check whether the script passes the PostgreSQL password to temporal-sql-tool as reported.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker, docker-compose, elasticsearch, postgresql, shell
- Domain
- databases, devops
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 68/100