temporalio / temporalio/samples-server
[Bug] compose/scripts/create-namespace.sh： $MAX_ATTdMPTS
Open
Beginner friendly
Nobody has claimed this yet.
bug
- Dominant language
- Go
- Stars
- 124
- Forks
- 71
- PR merge metrics
- No merged PRs in 30d
Description
What are you really trying to do?
Describe the bug
A typo. In the third while loop of the script, this line:
if [ "$attempt" -ge "$MAX_ATTdMPTS" ]; then
should indeed be:
if [ "$attempt" -ge "$MAX_ATTEMPTS" ]; then
The variable is correctly defined as MAX_ATTEMPTS at the top of the file, and it is used correctly everywhere else in the script. Only that single occurrence is misspelled as MAX_ATTdMPTS.
Minimal Reproduction
Environment/Versions
- OS and processor: [e.g. M1 Mac, x86 Windows, Linux]
- Temporal Version: [e.g. 1.14.0?] and/or SDK version
- Are you using Docker or Kubernetes or building Temporal from source?
Additional context
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open compose/scripts/create-namespace.sh and inspect the third while loop alongside the MAX_ATTEMPTS definition and its other uses. Correct the single misspelled variable reference and verify that all occurrences use the defined name.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- shell
- Domain
- devops
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 95/100