temporalio / temporalio/samples-python

[Bug] Infrequent polling test not properly skipped during time skipping

Open
#184 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Python
Stars
367
Forks
121
Avg merge
3d 20h
Merged PRs (30d)
11

Description

Describe the bug

#152 added test_infrequent_polling_workflow, but put

    if not env.supports_time_skipping:
        pytest.skip("Too slow to test with time-skipping disabled")

when likely meant

    if env.supports_time_skipping:
        pytest.skip("Too slow to test with time-skipping disabled")

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Find the test_infrequent_polling_workflow test added by issue #152 and inspect its supports_time_skipping guard. Verify the skip condition matches the intended slow-test behavior, then run that test and confirm it is skipped or executed in the appropriate environment.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing-qa
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.