temporalio / temporalio/samples-go
Add test for NonRetryableErrors
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 749
- Forks
- 248
- Avg merge
- 4d 2h
- Merged PRs (30d)
- 8
Description
As of today there are no integration level tests for NewNonRetryableApplicationError. This is a problem because we reference the feature in our docs and its a bit hard to find any info on it. '
We do have a test which specifies non-retryable errors: https://github.com/temporalio/sdk-go/blob/06e1ca56f3a286e072a048576b5e372ea0a497d6/internal/internal_workflow_testsuite_test.go#L2456
But seems to do so incorrectly:
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing NewNonRetryableApplicationError and the referenced cases in internal/internal_workflow_testsuite_test.go around lines 2359 and 2456. Add an integration-level test covering the non-retryable behavior, and consider the work complete when the test demonstrates the documented behavior and passes with the Go test suite.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- testing
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100