temporalio / temporalio/samples-go
[Bug] reqrespactivity/reqrespquery samples have wrong assumpion about Selector.HasPending
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 749
- Forks
- 248
- Avg merge
- 4d 2h
- Merged PRs (30d)
- 8
Description
Describe the bug
When I originally developed the reqrespactivity/reqrespquery code, I had a misunderstanding about HasPending() in that I improperly assumed it would return true while a future is outstanding which is not the case, it only returns true if the future is completed and just not handled.
The samples need to be updated to not exit their loop while selector.HasPending or there are unresolved futures.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the reqrespactivity and reqrespquery samples, focusing on the loop that checks Selector.HasPending(). Trace how unresolved futures are represented and verify the samples do not exit while either pending selector work or unresolved futures remain. Done means both samples continue until all relevant work has been handled.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- distributed-systems
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 50/100