temporalio / temporalio/samples-go
[Bug] devcontainer usage
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 749
- Forks
- 248
- Avg merge
- 4d 2h
- Merged PRs (30d)
- 8
Description
What are you really trying to do?
Goal: use the vscode devcontainer implementation with a minimum of configuration/overrides/additions.
Got things working as described below. Looking for guidance on these "fixes", and suspecting the documentation should be updated to be more clear on these points.
Describe the bug/repro/fixes
There seem to be two things required to get examples to run.
- The docker network ("temporal") is not configured for use as the DefaultHostPort by the Temporal Go SDK, which means the default
127.0.0.1:7233produces failure until its correctly addressed. The following modification describes the change necessary to everyc, err := client.Dial(client.Options{})encountered in the examples.
clientOptions := client.Options{
HostPort: "temporal:7233",
}
c, err := client.Dial(clientOptions)
Is there a way to globally set the HostPort default to temporal:7233?
- To get the containers to all start, I added empty
development_es.yamlat<repo>/.devcontainer/dynamicconfig/development_es.yaml.
Thank you for this repository.
Environment/Versions
OSX Monterey, Intel Chip
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the repository's .devcontainer configuration, including dynamicconfig/development_es.yaml, and the Go examples that call client.Dial(client.Options{}). Reproduce the devcontainer setup and verify the temporal:7233 connection behavior and container startup. Done means the required configuration and any documentation guidance are clear for running the examples.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker, go
- Domain
- developer-experience, devops
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100