temporalio / temporalio/samples-dotnet
[Bug] AesGcm instance should not be reused in EncryptionCodec
Open
Nobody has claimed this yet.
bug
- Dominant language
- C#
- Stars
- 114
- Forks
- 42
- Avg merge
- 4d 9h
- Merged PRs (30d)
- 14
Description
Describe the bug
AesGcm is not thread safe, so it is dangerous to share in the codec. See https://github.com/dotnet/runtime/discussions/71198 and other places.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating EncryptionCodec and its AesGcm usage in the samples-dotnet repository. Confirm how the codec shares the instance, then verify that encryption no longer reuses a non-thread-safe AesGcm instance; the issue names no test file or entry point.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- cryptography
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100