temporalio / temporalio/features
Ensure tests exist to confirm custom slot supplier slot info has proper fields
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- Go
- Stars
- 32
- Forks
- 28
- Avg merge
- 1d 9h
- Merged PRs (30d)
- 7
Description
Describe the solution you'd like
In many (all?) SDKs, there are not tests confirming that the fields are properly set on slot infos passed to custom slot suppliers.
Per-SDK Tickets
- Go - https://github.com/temporalio/sdk-go/issues/2045
- Java - https://github.com/temporalio/sdk-java/issues/2650
- Core - N/A
- TypeScript - https://github.com/temporalio/sdk-typescript/issues/1782
- Python - https://github.com/temporalio/sdk-python/issues/1079
- .NET - https://github.com/temporalio/sdk-dotnet/issues/519
- Ruby - https://github.com/temporalio/sdk-ruby/issues/225#issuecomment-3258196306
- PHP - No custom slot suppliers
- Temporal CLI - N/A
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the per-SDK tickets linked in the issue, beginning with the SDK you plan to change. Inspect the existing custom slot supplier tests and identify which slot-info fields need verification. Done means each applicable SDK has tests confirming those fields are properly populated.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp, go, java, php, python, ruby, typescript
- Domain
- testing-qa
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100