temporalio / temporalio/features

[Features Platform] Remove TEMPORAL_FEATURES_DISABLE_WORKFLOW_COMPLETION_CHECK workaround

Open
#581 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
32
Forks
28
Avg merge
1d 9h
Merged PRs (30d)
7

Description

In https://github.com/temporalio/features/pull/577 the env var TEMPORAL_FEATURES_DISABLE_WORKFLOW_COMPLETION_CHECK was introduced to workaround a problem when running tests against cloud. This should be resolved correctly and the env var removed.

The problem is described here

We have a bit of older logic that checks after our tests if any workflows are still running. Repeatedly every 100ms, to a max of 5s, it makes a Go SDK ListOpenWorkflowExecutions + ListClosedWorkflowExecutions call to see if any of the returned workflows have a status of WORKFLOW_EXECUTION_STATUS_RUNNING. If after 5s there is still one with that status, we fail. We saw sometime approx between Oct 10th and Oct 25th, our assertion here started failing in cloud (and still does). The workflows were completing (in milliseconds) but even after 5s these were returning stale data in cloud saying that status was still running.

https://github.com/temporalio/features/pull/579 has updated to use the preferred ListWorkflow API, but the problem remains.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing pull requests 577 and 579, then trace the workflow-completion check that uses the Go SDK ListWorkflow API. Reproduce the cloud-test behavior and identify why completed workflows can still appear running. Done means the workaround environment variable is removed and the completion check reliably passes against cloud.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cloud, testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.