temporalio / temporalio/features

Provide flag to tell the update handler that the handling is from a re-apply

Open
#564 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Go
Stars
32
Forks
28
Avg merge
1d 9h
Merged PRs (30d)
7

Description

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

In non-reset case, we will have a short or no activity retry, so that the error would return to the caller/client early.
However, on a retry with re-apply, we need to ensure the activity will not fail, because the update has been considered completed (just like signal has been accepted) from the client.

Right now this is not possible.

Kinda related to https://github.com/temporalio/temporal/issues/5873
If the workflowContext can tell that the workflowTask is from a reset, that's probably enough?

Describe the solution you'd like
A clear and concise description of what you want to happen.
SDK should know this info (the update is from Admitted event), just provide a flag to us.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
NA

Additional context
Add any other context or screenshots about the feature request here.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the update handler and workflowContext behavior described in the issue, then read related issue #5873 and trace how the Admitted event and re-apply path are represented. Done means the SDK receives a way to identify re-applied updates and the re-apply activity does not fail after the update is considered completed.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend-api-design, distributed-systems
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.