temporalio / temporalio/features

Set identity to `ClientOptions.identity` in all possible client calls

Open
#193 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Go
Stars
32
Forks
28
Avg merge
1d 9h
Merged PRs (30d)
7

Description

Tiho reports it's not set on terminate in Java.

In TS, it's set on:

  • terminate
  • cancel
  • start
  • signal
  • signalWithStart

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare the Java client calls, starting with terminate, against the referenced TypeScript implementation in packages/client/src/workflow-client.ts and its terminate, cancel, start, signal, and signalWithStart paths. Verify that ClientOptions.identity is set consistently in each applicable call, then use the repository's compatibility tests to confirm the behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, typescript
Domain
api, backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.