temporalio / temporalio/features

Support valid proto JSON in SDK replayers

Open
#164 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Go
Stars
32
Forks
28
Avg merge
1d 9h
Merged PRs (30d)
7

Description

Our generated Go API uses this patch which causes tooling like the web UI and CLI to generate invalid JSON protos when exporting histories, converting CONSTANT_CASE enum values to CamelCase.

SDK replayers should support the hacked JSON output as well as valid proto JSON output to allow downloading histories programmatically in addition to the CLI and UI.
Eventually we could get rid of the hacked JSON output generation and remove the custom conversion code in all SDKs which reverts the hack.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by examining the SDK replayers and their history JSON import paths, then compare how they handle valid proto JSON with the hacked JSON emitted by the web UI and CLI. The work is done when replayers accept both JSON forms and histories can be downloaded programmatically without conversion failures; the issue also notes eventual removal of the custom conversion code across SDKs.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
testing
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.