[Feature Request] Show actual error message when mTLS certs are missing
Open
@feedmeapples is already working on this.
Since May 4, 2023.
enhancement
- Dominant language
- Go
- Stars
- 379
- Forks
- 103
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 23
Description
Is your feature request related to a problem? Please describe.
Right now, if mTLS certs (--tls-cert-path and --tls-cert-path) are left out by mistake, the cli returns an empty error.
➜ workflow reset --address='<namespace>.tmprl.cloud:7233' --namespace='<namespace>' --workflow-id "fbfcc301-e801-48c0-8bba-4d8b4afcfe7d" --reason test --event-id 3 --run-id "ac56c805-87fa-486d-af43-eb9fb54518a6"
Error: reset failed:
('export TEMPORAL_CLI_SHOW_STACKS=1' to see stack traces)
Describe the solution you'd like
It would be more helpful if it tells you want went wrong, e.g. server requires mTLS so please provide --tls-cert-path and --tls-cert-path.
Additional context
Similar issue was previously reported in tctl in https://github.com/temporalio/tctl/issues/228 and https://github.com/temporalio/tctl/issues/353. At least one Temporal customer has submitted a support ticket with this issue.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.