telefonicaid / telefonicaid/iotagent-node-lib
Question: Should the library expose more common functions?
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 62
- Forks
- 90
- Avg merge
- 2h 35m
- Merged PRs (30d)
- 1
Description
#1119 has abstracted HTTP requests from the IoT Agents, should other common library functions such as logops be exposed by the IoT Agent node lib. Looking at the dependencies:
iotagent-node-lib
"dependencies": {
"async": "2.6.2",
"body-parser": "~1.19.0",
"command-shell-lib": "1.0.0",
"express": "~4.16.4",
"got": "~11.8.2",
"jexl": "2.3.0",
"jison": "0.4.18",
"logops": "2.1.0",
"moment": "~2.24.0",
"moment-timezone": "~0.5.25",
"mongodb": "3.6.8",
"mongoose": "5.7.7",
"mu2": "~0.5.20",
"query-string": "6.5.0",
"revalidator": "~0.3.1",
"underscore": "~1.12.1",
"uuid": "~3.3.2"
}
A random IoT Agent
"dependencies": {
"amqplib": "~0.5.1",
"async": "2.6.1",
"body-parser": "1.18.3",
"dateformat": "3.0.3",
"express": "~4.16.4",
"logops": "2.1.0",
"mqtt": "3.0.0",
"underscore": "1.12.1"
}
Things like async or mongoose or logops or express or underscore could be exposed and standardized more easily across agents.
Also, do you really need both dateformat and moment ? Surely they are doing the same job?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review issue #1119 and compare the dependency lists shown for iotagent-node-lib and another IoT Agent. Determine which common functions should be exposed or standardized, and whether dateformat and moment overlap. Done means documenting a decided scope; no implementation file or test is named.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, node.js
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100