telefonicaid / telefonicaid/iotagent-node-lib

device attribute of type "Point" is translated to entity as geo:json

Open
#1,012 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
62
Forks
90
Avg merge
2h 35m
Merged PRs (30d)
1

Description

This is breaking previous client integrations

Comes from https://github.com/telefonicaid/iotagent-node-lib/pull/854

Translation is done by https://github.com/telefonicaid/iotagent-node-lib/blob/master/lib/services/ngsi/entities-NGSI-v2.js#L59

Possible Fix: https://github.com/telefonicaid/iotagent-node-lib/pull/1013

  • Need checks other types (like geo:point, etc) to keep previous behaviour
  • Need update tests
  • Need update doc

geo types involved:
geoproperty, point, geo:point,
linestring, geo:linestring,
polygon, geo:polygon,
multipoint, geo:multipoint,
multilinestring, geo:multilinestring,
multipolygon, geo:multipolygon

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at lib/services/ngsi/entities-NGSI-v2.js line 59 and review PR 1013 to understand the proposed translation change. Check the existing tests and documentation for the listed geo types, then run the relevant test suite. Done means previous behavior is preserved for all listed types and the tests and documentation are updated.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
api, backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.