tektoncd / tektoncd/pipelines-as-code
pipelinesascode_test.go is not testing thing properly
Open
Nobody has claimed this yet.
bug
priority/low
refactoring
testing
- Dominant language
- Go
- Stars
- 214
- Forks
- 144
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 27
Description
the pipelinesascode_test.go is currently buggy:
it doesnt' check errors or pending it actually only test the completed state.
generally it try to do too much with a single testcase when it probably should be refactored with indivudal tests....
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with pkg/pipelineascode/pipelineascode_test.go around line 95 and inspect how the current test handles completed, pending, and error states. Refactor the oversized test into individual cases that assert each state, with completion criteria covering errors and pending results as well as the existing completed state.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- ci-cd, testing-qa
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100