tektoncd / tektoncd/pipelines-as-code
Code Enhancement: Merge patch calls in PAC controller
Open
Nobody has claimed this yet.
feature
priority/low
refactoring
- Dominant language
- Go
- Stars
- 214
- Forks
- 144
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 27
Description
In controller after creating pipelineruns we do 2 patch calls
- https://github.com/openshift-pipelines/pipelines-as-code/blob/15d27261cb6419b96a49a32d5a9666077618c086/pkg/pipelineascode/pipelineascode.go#L174
the first one is for patching logURL annotation - https://github.com/openshift-pipelines/pipelines-as-code/blob/15d27261cb6419b96a49a32d5a9666077618c086/pkg/pipelineascode/pipelineascode.go#L92 the second one happens for patching order execution annotation when concurency is enabled.
This 2 patch calls can be clubbed together
Make sure the logic is not changing
- 2nd call happens only when concurrency is enabled
- 1st happens for all events except from GitHub App
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in pkg/pipelineascode/pipelineascode.go at the referenced lines and trace the two patch calls made after creating pipelineruns. Confirm how the logURL and order execution annotations are assembled, then verify that the combined call preserves the GitHub App and concurrency conditions described in the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend, ci-cd
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100