tektoncd / tektoncd/operator

Service monitors deployed by tektonInstallerSets have incorrect monitoring namespace

Open
#1,595 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

kind/bug lifecycle/rotten
Dominant language
Go
Stars
608
Forks
263
Avg merge
1d 3h
Merged PRs (30d)
125

Description

Expected Behavior

ServiceMonitor (monitoring.coreos.com/v1) installed in target namespace by TektonInstallerSets should have monitoringNamespace = targetNamespace.

Actual Behavior

The monitoring namespace in service monitor is openshift-pipelines rather than the target namespace specified in tektonConfig.

Steps to Reproduce the Problem

  1. Install the openshift-pipelines operator. Disable the default tektonconfig with AUTOINSTALL_COMPONENTS set to false
  2. Create the tektonconfig custom resource with targetNamespace set (different from openshift-pipelines)
  3. View the servicemonitors deployed in target namespace.

Screenshot

Screenshot from 2023-06-26 12-01-14

Additional Info

  • OpenShift version: 4.11.42
  • Kubernetes version: v1.24.12+ceaf338
  • Openshift Pipelines Operator version: v1.10.4
  • Tekton Pipelines version: v0.44.2

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how TektonInstallerSets generate ServiceMonitor resources and how targetNamespace is read from tektonConfig. Reproduce the issue with a target namespace different from openshift-pipelines; done when the generated monitoringNamespace matches the target namespace and the behavior is covered by a regression test.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, kubernetes
Domain
observability
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.