tektoncd / tektoncd/operator

"verification-mode" field should be removed from pipelines spec

Open
#1,497 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

lifecycle/frozen
Dominant language
Go
Stars
608
Forks
263
Avg merge
1d 3h
Merged PRs (30d)
125

Description

Originally verification-mode from pipelines spec was removed in https://github.com/tektoncd/operator/pull/1481, but upgrade blocked with the following error,

{"level":"info","logger":"tekton-operator-webhook","caller":"webhook/admission.go:151","msg":"remote admission controller audit annotations=map[string]string(nil)","commit":"8e8c163","knative.dev/kind":"operator.tekton.dev/v1alpha1, Kind=TektonConfig","knative.dev/namespace":"","knative.dev/name":"config","knative.dev/operation":"UPDATE","knative.dev/resource":"operator.tekton.dev/v1alpha1, Resource=tektonconfigs","knative.dev/subresource":"","knative.dev/userinfo":"system:serviceaccount:openshift-operators:openshift-pipelines-operator","admissionreview/uid":"958be8bd-9d63-4b95-aa7d-9285684ff86c","admissionreview/allowed":false,"admissionreview/result":"&Status{ListMeta:ListMeta{SelfLink:,ResourceVersion:,Continue:,RemainingItemCount:nil,},Status:Failure,Message:mutation failed: cannot decode incoming old object: json: unknown field \"verification-mode\",Reason:BadRequest,Details:nil,Code:400,}"}

hence verification-mode field added back to pipelines spec with the PR => https://github.com/tektoncd/operator/pull/1498

verification-mode should be removed, keep this ticket open until verification-mode removed.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the pipelines spec and the changes in PRs 1481 and 1498, then trace the webhook admission error for upgrades involving an old object. Done means verification-mode is removed without causing the reported decode failure during an operator upgrade.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, kubernetes
Domain
devops, infrastructure
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.