tektoncd / tektoncd/cli

ci: Run zizmor on GitHub Actions and fix security findings

Open
#2,782 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

kind/cleanup
Dominant language
Go
Stars
461
Forks
277
Avg merge
16h 48m
Merged PRs (30d)
95

Description

Description

Run zizmor, a static analysis tool for GitHub Actions, on this repository's workflows to identify and fix security issues. Add zizmor as a CI check.

This follows the same work done in tektoncd/pipeline#9667.

What needs to be done

  1. Run zizmor --fix=all . to auto-fix findings:

    • Add persist-credentials: false to all actions/checkout steps (artipacked)
    • Fix template injection by replacing ${{ }} in run: blocks with shell env vars (template-injection)
  2. Add zizmor CI workflow (.github/workflows/zizmor.yaml) that runs on pushes to main and PRs, uploading SARIF results to GitHub Advanced Security

  3. Fix remaining non-auto-fixable findings manually:

  4. File follow-up issues for any remaining findings that require broader changes (e.g., secrets-outside-env, secrets-inherit)

Reference

/kind cleanup

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running zizmor --fix=all . against the repository's GitHub Actions workflows and review the remaining findings. Add .github/workflows/zizmor.yaml for pushes to main and pull requests, including SARIF upload, then address the listed permissions, template-injection, and superfluous-action findings. Done means the CI check runs and remaining broader findings have follow-up issues.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions
Domain
ci-cd, security
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.