tee-ar-ex / tee-ar-ex/trx-python
Circular Dependency for DIPY ?
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 26
- Forks
- 20
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 9
Description
Hi @frheault, Hi @arokem,
I would like to start integrating TRX in DIPY.
However:
- I see that some part of TRX depends on DIPY
- if I add TRX as a DIPY dependency, it looks like we enter in a circular dependency which will create weird issues.
What is the best approach to solve this coming issue ?
- Integrate TRX in Nibabel ?
- integrate Stateful Tractogram in Nibabel (this is not the only DIPY element used in this package)
- Integrate TRX in DIPY ?
- Other ideas ? @garyfallidis ?
Thank you for your feedback !
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the TRX components that depend on DIPY and the package dependency declarations first, then compare the proposed DIPY, NiBabel, and TRX integration boundaries. Done means an integration direction is agreed that removes the circular dependency and the resulting dependency graph installs cleanly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100