Support unit64 offsets
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 4
- Forks
- 10
- Avg merge
- 9m
- Merged PRs (30d)
- 1
Description
Currently, if I try to load a trx file using trx-cpp that has offsets larger than int32 max, it segfaults. This PR may be related: #49
With pyAFQ, we sometimes generate tractograms with 100s of millions of streamlines, and here, TRX is super convenient (really the only file format that can handle that many streamlines). These work with trx-python but not trx-cpp. Let me know if you would like me to provide files to reproduce the error. Maybe I am doing something wrong on my end, but I think it's caused by int32 being hardcoded in certain places.
Thank you,
John Kruper
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the offset handling in trx-cpp and related PR #49, then reproduce the failure with a TRX file containing offsets above the int32 limit. Done means large-offset TRX files load without a segmentation fault and the relevant behavior is covered by a regression test.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- data
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100