techyCoder81 / techyCoder81/smashnet
get rid of the unwraps inside the curling functions
Open
Nobody has claimed this yet.
bug
- Dominant language
- Rust
- Stars
- 1
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Description
As an example of what this can cause:
thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value:
Custom { kind: NotFound, error: "Path must be absolute" }', src/curl.rs:142:47
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace```Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/curl.rs, especially the unwrap at line 142, and inspect the other unwraps inside the curling functions. Trace how their errors are currently represented and define handling for the shown “Path must be absolute” failure. Done means those curling paths no longer panic through Result::unwrap().
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100