techyCoder81 / techyCoder81/hdr-launcher-react
verify crashes on install because arcrop isnt loaded
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 16
- Forks
- 10
- PR merge metrics
- No merged PRs in 30d
Description
problem
when using the launcher to install HDR, the last step is to run Verify. However, Verify currently crashes, most likely because it is attempting to use the arcropolis API to check if HDR is enabled, but arcropolis is not available. Because arcropolis is a dependency that gets installed, it will not yet be loaded by smash and have its symbols present for us to call, and therefore when we do, we segfault.
solution
we should be checking if the symbol is valid before calling it.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the launcher's Verify step, which runs after HDR installation, and trace its check for whether HDR is enabled. Confirm how the Arcropolis symbol is accessed; done means Verify safely handles the symbol being unavailable instead of crashing during installation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100