technicalpickles / technicalpickles/cq
release-please double-lists a fix when the PR merges via merge commit
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 11
- Forks
- 1
- Avg merge
- 4h 43m
- Merged PRs (30d)
- 22
Description
Found this poking at why PR #25 (the pending 0.3.0 release PR) wasn't picking up every merge to main. Turns out it was working fine, but along the way I noticed the changelog in #25 lists the DuckDB JSON-reader fix twice:
* skip records DuckDB's JSON reader rejects instead of crashing (967dec9)
* skip records DuckDB's JSON reader rejects instead of crashing :bug: (c743865)
967dec9 is the actual fix: commit from PR #26. c743865 is the merge commit for that PR, and its message happens to repeat the conventional-commit line from the PR title:
Merge pull request #26 from ivy/fix/skip-unparseable-records
fix: skip records DuckDB's JSON reader rejects instead of crashing :bug:
Since this repo merges PRs with merge commits (not squash), release-please's commit parser sees both commits, and the merge commit's body happens to parse as a second, independent conventional commit. So every PR merged this way gets double-counted in the changelog.
Doesn't affect versioning here (already a minor bump either way), just cosmetic duplication. A couple ways to fix it:
- Squash-merge PRs instead of merge-commit-merging, so only one conventional commit lands on main per PR.
- Or configure release-please (if there's a knob for it) to skip merge commits when parsing.
I'd lean toward squash merging going forward since it also keeps main's history flatter, but flagging both options.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the repository's release-please configuration and reviewing how merge commits are parsed. Reproduce the pending 0.3.0 changelog behavior around PR #26, then verify that a merge-commit merge produces one DuckDB JSON-reader fix entry rather than two, without changing the version bump.
Written by the indexing model from the issue text.
Assessment
- Domain
- ci-cd, release
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100