tc39 / tc39/test262

Getter tests doesn't cover full PropertyName

Open
#703 5 comments 0 reactions 1 assignee View on GitHub

@jugglinmike is already working on this.

Since Jun 28, 2016.

Dominant language
JavaScript
Stars
2.8k
Forks
564
Avg merge
3d 7h
Merged PRs (30d)
10

Description

MethodDefinition[Yield]:
  PropertyName[?Yield] `(` StrictFormalParameters[~Yield]`)` `{` FunctionBody[~Yield] `}`
  GeneratorMethod[?Yield]
  `get` PropertyName[?Yield] `(` `)` `{` FunctionBody[~Yield] `}`
  `set` PropertyName[?Yield] `(` PropertySetParameterList `)` `{` FunctionBody[~Yield] `}`

PropertyName[Yield]:
  LiteralPropertyName
  ComputedPropertyName[?Yield]

LiteralPropertyName:
  IdentifierName
  StringLiteral
  NumericLiteral

There seems to be currently no coverage for get followed by StringLiteral or NumericLiteral. At least not in https://github.com/tc39/test262/tree/master/test/language/expressions/object

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.