Iterator/concat/next-method-returns-throwing-value-done.js is outdated
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 2.8k
- Forks
- 564
- Avg merge
- 3d 7h
- Merged PRs (30d)
- 10
Description
test/built-ins/Iterator/concat/next-method-returns-throwing-value-done.js incorrectly throws ValueGetterError since https://github.com/tc39/proposal-iterator-sequencing/pull/19 has introduced an extra IteratorValue step:
2. If _iteratorResult_ is ~done~, then
a. Perform ? IteratorValue(_iteratorResult_).
The test should be changed to expect Iterator.concat getting the value of the iterator result when the underlying iterator is done.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with test/built-ins/Iterator/concat/next-method-returns-throwing-value-done.js and compare its expectation with the Iterator.concat behavior described in proposal-iterator-sequencing PR 19. Update the test so completion reads the iterator result's value, then run this Test262 test to confirm it no longer expects ValueGetterError.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- testing-qa
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 68/100