tc39 / tc39/proposal-json-parseimmutable
Spec review comments
Open
Nobody has claimed this yet.
- Dominant language
- HTML
- Stars
- 48
- Forks
- 4
- Avg merge
- 1d 1m
- Merged PRs (30d)
- 5
Description
My part of #14.
- 1.1.1: I think it's quite confusing to keep calling the parameter
reviver; seems like it should be updated to something likereviverOrOptions. - 1.1.1: "configuring native transforms" feels like it could be clearer. Maybe "allowing built-in transforms to be chosen"?
- 1.1.1.{5,6}: I know these aren't actual JS functions but I was initially shocked that the options argument doesn't come last. 😱 I guess by this point though it's a record and not just an options bag, so maybe it's fine.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading proposal section 1.1.1 and the related work in issue #14. Review the three comments about parameter naming, transform wording, and argument order, then update the specification only after each point has a clear decision and the revised text reflects it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- documentation
- Issue type
- Documentation
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100